Integrate react-native-fast-shadow for Android shadows #4
+9,075
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces `react-native-fast-shadow` to handle shadow rendering for the slider thumb, aiming for better performance and customizability on Android. Key changes: - Added `react-native-fast-shadow` as a dependency. - Modified `src/Slider.js` to use the `ShadowedView` component from `react-native-fast-shadow` to wrap the thumb. Default shadow properties have been applied. - Removed old shadow styles (`shadowColor`, `shadowOffset`, `shadowOpacity`, `shadowRadius`) from thumb styles in `Example/app.js` as these are now managed by `ShadowedView` in the core `Slider` component. Note: Due to limitations in my current environment, I couldn't fully visually verify the example app. Please ensure compatibility of `[email protected]` with `[email protected]` during your review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces
react-native-fast-shadowto handle shadow rendering for the slider thumb, aiming for better performance and customizability on Android.Key changes:
react-native-fast-shadowas a dependency.src/Slider.jsto use theShadowedViewcomponent fromreact-native-fast-shadowto wrap the thumb. Default shadow properties have been applied.shadowColor,shadowOffset,shadowOpacity,shadowRadius) from thumb styles inExample/app.jsas these are now managed byShadowedViewin the coreSlidercomponent.Note: Due to limitations in my current environment, I couldn't fully visually verify the example app. Please ensure compatibility of
[email protected]with[email protected]during your review.